idk i've played though FF7 a number of times and Cloud just comes off as a kind of smug with a bit of angst here and there, it isn't until Aerith's death that he becomes more emo and starts to realize his identity is a lie or whatever and even then just becomes more introverted and guilt-ridden at best
if you REALLY want a whiny protagonist, it's fucking Tidus, not only is he an obnoxious prick who won't shut up, he consistently whines about his daddy issues to the point of nausea, and near the end i ended up sympathizing with Jecht way more, if i had that little bitch as a son i'd treat him like shit too
I'm more inclined to say Squall. Good heavens if he's not the most uninteresting block of meat with a mouth around for most of Final Fantasy VIII.
But then, I dislike VIII for a large variety of reasons, so I'm probably prejudiced against him to begin with.