Homebrew Citra - Unofficial \ Chinese builds discussion

Miguel Gomez

Well-Known Member
Member
Joined
Jan 10, 2016
Messages
2,867
Trophies
0
Age
25
Location
Planet Earth
XP
1,530
Country
upload_2017-10-30_10-30-15.png

upload_2017-10-30_10-31-3.png


--------------------- MERGED ---------------------------

RIP

--------------------- MERGED ---------------------------

upload_2017-10-30_10-31-49.png
 

Attachments

  • upload_2017-10-30_10-31-35.png
    upload_2017-10-30_10-31-35.png
    58.9 KB · Views: 155

drwhojan

Well-Known Member
Member
Joined
Jul 14, 2009
Messages
4,196
Trophies
1
Age
45
Location
Where I Am!
XP
1,702
Country
United Kingdom
I
There are no 3D models in the game, just sprites. I don't see why it runs so slow. Maybe you could see if you can speed it up a notch somehow?

no think more can be done wit the speed.

--------------------- MERGED ---------------------------

smm fix (v4.0)
only works with my build

To delete the following files someone need to come up with a better bat file
@Echo off
title Citra Mario Maker Fixer
if exist "user" cd "user\sdmc\Nintendo 3DS\00000000000000000000000000000000\00000000000000000000000000000000\extdata\00000000\00001A04\user"
if not exist "user" cd "%appdata%\citra\sdmc\Nintendo 3DS\00000000000000000000000000000000\00000000000000000000000000000000\extdata\00000000\00001A04\user"
cls
if exist course216 del course216
if exist course217 del course217
if exist course218 del course218
if exist course219 del course219
if exist course220 del course220
if %ERRORLEVEL% == 1 goto err
echo Fixed, Restart Citra.
echo You need to run this every time you want to play the game.
pause
exit
:err
echo Error!!!
echo SMM save data not found/Fixed!
timeout 5

Also found minecraft has the same @ folder 00001A04
------

I'm trying to find out what one of your commits may have fixed it, but they is that many to go though.

EDIT: best thing to do download your repo, role it back it time and keep compiling in msvc 2017 to the point of its fix
edit: save from the 9th oct , bad from 5th, getting warmer .

9/7th yes
 
Last edited by drwhojan,

drwhojan

Well-Known Member
Member
Joined
Jul 14, 2009
Messages
4,196
Trophies
1
Age
45
Location
Where I Am!
XP
1,702
Country
United Kingdom
The branch that work's Mario Maker is.. Also DKCR
https://github.com/Jhon591/citratest1/commit/383431972a34abcde8432c186d0834d1744df858

Issue i was having with this branch that the new builds of citra no longet like std::max in this area
it should be
Code:
const s32 priority = std::max(ready_queue.get_first()->current_priority - 1, 0);

So i remove std::max and it compiled, now yes it also needs - 1, 0); at the end for loading/saving

here's a other branch
https://github.com/citra-emu/citra/compare/master...Dragios:priority-boost

->current_priority - 1,
will make DKCR load but random freezing, but will load the game at loading screen.
--------
so how we need to keep the original line.. of ?
Code:
const s32 priority = std::max(ready_queue.get_first()->current_priority - 1, 0);

And fix the, std::max

Anyone from citra devs have any ideas on this ?
-----
EDIT:
this line not much good, Seed gets half eaten..
Code:
const s32 priority = std::max(ready_queue.get_first()->current_priority - 1,
 static_cast<unsigned int>(0));
-----
EDIT: added comment to the commit ?
https://github.com/Jhon591/citra/commit/5c7a617094888d2b285a31fb742e971dfdd6138c
 
Last edited by drwhojan,
  • Like
Reactions: valentinvanelslande

Site & Scene News

Popular threads in this forum

General chit-chat
Help Users
  • No one is chatting at the moment.
    OctoAori20 @ OctoAori20: Nice nice-