I posted when the thread was new, but I am going to add some games that I enjoyed all of the music in the game
But before I become unfair to the rest of the list, Yoshi's Island wins, there now that that's out of the way, here's the rest.
The World Ends with You: I really loved the soundtrack to that game, all of the songs were just amazing. It was that soundtrack that kept me returning to that game.
Pokemon R/S/E: They were great upgrades to the games and a great upgrade to the music.
Shin Megami Tensei - Devil Survivor: The music just worked perfectly with the game and set the mood perfectly
Persona 4: Persona 4
Halo: As I said before not a big fan of the games, but the music in the first game was quite amazing.
Persona 3: Not my favorite Persona, but the music was good.