the cro++ branch is going through the final checks before merging.
Except it is not..
Take
texture forwarding or each of the audio PRs:
Texture forwarding was "just" 1700 lines, took one month to be integrated.
Audio was a larger number of smaller PRs, ranging from 1 day to 15 days for integration.
All of that was during winter when devs weren't outside, spending their time in the sun.
Furthermore the mean time for integration must have been like 7-14 days or something back then.
If you check the current PR list you'll notice that 11 PRs are 2-3 months old, 2 are 1-2 month old and only 6 are from the last 2 weeks.
Some of those old PRs are stuck in review, sure. But that still means our mean time to merge is counted in weeks at least.
CRO is a huge PR, 2700 lines. That will take *A LOT* of time to review (despite wwylele doing a great job explaining everything and following the code guidelines).
I don't think it will be merged before end of August to be honest.
His code is a lot nicer, but integrating a couple hundred of lines of my geometry shader branch took about 2 months.. (if I remember correctly).
Chances are there will be less conflicts with CRO, but it's still a lot of code which must be reviewed carefully.
Also, thanks to due amount of Pokemon spam we'd get then, motivation on this appears to be very low from a developer perspective.
I also think it'd be wise to implement custom shared-font first to avoid large-scale piracy and / or support requests first.
I haven't checked Pokemon without GS either, but if it uses geometry shaders we should probably fix them first too, just so we don't get a ton of support requests for graphical issues (especially with Pokemon GO and the new Pokemon titles around the corner, which means a lot more Pokemon traffic than usual).
At the very least it would be wise to add a disclaimer when booting Pokemon games about current issues imo.
I certainly wouldn't call it "final checks before merging".
