The remapped buttons work great!I hope it works out for you. I only tested a few of the buttons. I couldn't remember what the buttons even did to begin with as it's been a while since I've played sunshine.
Z on Minus and the clockwise face buttons work as desired.
However, the only issue seems to be with the L/R and ZL/ZR buttons.
An easy way to test the desired results is with either Mario Sunshine:
With Sunshine:
Pressing R by itself should make Mario throw water in a fixed position.If you move the DPad, only the aiming of the nozzle should move, while Mario still stays in place.
Pressing ZR should allow Mario to run and throw water at the same time.
If those work, then the code should simply be mirrored to L/ZL and that's it.
I'll check out the code tomorrow to see what could be happening.