ROM Hack [Release] Gen 1 Pokemon VC wild encounter DV NTR Overlay

[DocKlokMan]

offset for yellow is 0x0893053a

Seems they're a set offset away for each game so I think I have red versions offset. I've got about 90% of this new party option implemented. Should have a release in about 2 hours.

More efficient would be this:

unsigned char hp = ((atk & 1)<<3) + ((def & 1)<<2) + ((spe & 1)<<1) + (spc & 1);

AND 1 is faster than MOD 2 since you just want to reduce it to the least significant byte.
And bitshift operations are faster than multiplications.
There's possibly a better way but that would require some brainwork.

Additionally I would use unsigned chars (basically byte) instead of integers since you can't have negative values anyway and the game also handles the values in bytes I'd think since they cap at 255.

Thanks for that! I always like to learn and this works since the multiplication is in powers of two. I was balancing readibilty for performance because we're not really lacking in performance here.

 

[shadowofdarkness]

I have only had time to do Silver so far but it's even able to be added to the current plugin and it can be a universal plugin for gen 1 and 2 since the same offset works for detecting the version

At 0x0880014b check for 535F to detect Silver
The DV's are at 0x08a2f059

 

[DocKlokMan]

I have only had time to do Silver so far but it's even able to be added to the current plugin and it can be a universal plugin for gen 1 and 2 since the same offset works for detecting the version

At 0x0880014b check for 535F to detect Silver
The DV's are at 0x08a2f059

Since G/S/C have not been released yet, I'm not sure those addresses will work for every release that someone may be using (for example, there's a wifi trading version and a non wifi trading version out there) so I may hold off on implementing that one for now.

 

[DocKlokMan]

And would it be possible to implement checking the DVs of the first Pokemon in your party that way you can tell if your starter is shiny?

Updated to now show the stats of whatever Pokémon you're viewing on the party menu.

@Veund New update. I updated my attachment on the original post. Will upload new screenshots later.

@shadowofdarkness I've added Party Pokémon support.

If anyone wants to help improve this, I could use a value and offset that tells me when you're in a battle (as opposed to not) and in the party menu screen looking at a Pokémon. This will allow me to make the overlay only display relevant info on the screens that matter. Think these will be tougher to find and I didn't see anything concrete while looking through other forums research threads and RAM mappings.

 

[greenDarkness555]

So, when running Yellow on Old3DS, the frame rate drops pretty bad. Would it be possible to implement a way to toggle the calculator on and off?
Also, something odd happened with the alignment. Thanks for all the hard work guys.

 

[DocKlokMan]

So, when running Yellow on Old3DS, the frame rate drops pretty bad. Would it be possible to implement a way to toggle the calculator on and off?
Also, something odd happened with the alignment. Thanks for all the hard work guys.

Oops, my bad. I switched Speed and Special to match the order it was on the Pokemon Party screen and forgot the alignment. I'm also playing on Yellow and get no slow down, the calculations are super lightweight, if there's slowdown for you it's likely the boxes. When do you see frame drops so I can test.

 

[greenDarkness555]

No biggie. Ah okay! Are you on a N3DS? Or OLD3DS? Like it run slow as soon as the game launches. Same for Red as well, but it isn't as bad.

 

[DocKlokMan]

No biggie. Ah okay! Are you on a N3DS? Or OLD3DS? Like it run slow as soon as the game launches. Same for Red as well, but it isn't as bad.

Updated my post with the alignment fix. I'll work on something that'll help you out. Gonna have to wait a little though, I gotta go back to work.

 

[Deleted User]

can you PLEASE put some screenshots or videos? I wanna see what I download and run on my hardware...

 

[greenDarkness555]

Updated my post with the alignment fix. I'll work on something that'll help you out. Gonna have to wait a little though, I gotta go back to work.

Thanks I appreciate it. What are your thoughts on making the calculator toggleable?
Also, will the newest version always be on post #33?

can you PLEASE put some screenshots or videos? I wanna see what I download and run on my hardware...

• Do you have Red, Blue, or Yellow?

 

[Deleted User]

Thanks I appreciate it. What are your thoughts on making the calculator toggleable?

• Do you have Red, Blue, or Yellow?

of course...
EDIT- I think I misunderstood your question, I have BLUE and YELLOW

 

[Veund]

Is that offset for the Pokémon you're actively looking at on the status screen or for the last one in your party?

Weirdly enough its actually both

 

[DocKlokMan]

Thanks I appreciate it. What are your thoughts on making the calculator toggleable?
Also, will the newest version always be on post #33?

As I said, the calculations are likely not the issue, it's the drawing of the overlay most likely. And I'm working on it. I may make it so you need to hold X to see Wild Encounter stats and Y to see Party Stats. That way it's only visible when you need it to be until we can find out how to detect when we're in a battle or in the party menu.

And yes to post #33, at least unless the OP adds it to their post (or links to post #33).

--------------------- MERGED ---------------------------

Weirdly enough its actually both

Yeah, I figured that out. I have an idea why, it's just annoying is all.

 

[greenDarkness555]

of course...
EDIT- I think I misunderstood your question, I have BLUE and YELLOW

Yes, I was asking which you had specifically. Either way, you just need to unzip this, and put the plugin folder from here on the root of your SD card and it should work for any version.

 

[Deleted User]

Yes, I was asking which you had specifically. Either way, you just need to unzip this, and put the plugin folder from here on the root of your SD card and it should work for any version.

I dont think you understood me- I wanna see what I will run on my hardware B4 I download. just some screenshots or a video will be great...

 

[DocKlokMan]

Yes, I was asking which you had specifically. Either way, you just need to unzip this, and put the plugin folder from here on the root of your SD card and it should work for any version.

They wanted screen shots. Funny enough, you posted one right before they asked.

 

[greenDarkness555]

I dont think you understood me- I wanna see what I will run on my hardware B4 I download. just some screenshots or a video will be great...

Oh! Screenshots can be found here.
https://gbatemp.net/threads/release...ter-dv-ntr-overlay.459869/page-2#post-7102874

 

[Deleted User]

Oh! Screenshots can be found here.
https://gbatemp.net/threads/release...ter-dv-ntr-overlay.459869/page-2#post-7102874

sorry I didnt notice... so you are making versions better then the op's? why not make a separate thread about that? also did you implement removing and returning of the overlay? it could be great!

 

[greenDarkness555]

sorry I didnt notice... so you are making versions better then the op's? why not make a separate thread about that? also did you implement removing and returning of the overlay? it could be great!

No problem. I'm really not the person to ask (I'm just testing). But I'm pretty sure everyone is collaborating here, and OP just hasn't updated the initial post yet.

 

[Veund]

Updated to now show the stats of whatever Pokémon you're viewing on the party menu.

@Veund New update. I updated my attachment on the original post. Will upload new screenshots later.

@shadowofdarkness I've added Party Pokémon support.

If anyone wants to help improve this, I could use a value and offset that tells me when you're in a battle (as opposed to not) and in the party menu screen looking at a Pokémon. This will allow me to make the overlay only display relevant info on the screens that matter. Think these will be tougher to find and I didn't see anything concrete while looking through other forums research threads and RAM mappings.

I'll give it a shot but thats going to be a little harder, what i did find by accident is where the game stores the caught pomemons dv values but only untill the next battle, not sure if that helps anyone as the dv's are displayed one screen untill the next battle anyway