The official switch joycon are not only expensive, but also breaks easily
I personally prefer the official joy-cons and I doubt that you'll find some cheap alternatives that are of somewhat decent quality. As for them breaking, I assume you're talking a bout joysticks? Just order a few replacement ones from AliExpress. I've ordered around 20 of them just in case they ever break on me and so far I've replaced two. It's not really hard to replace them and the ones I've bought feel close to the original joysticks. No drift, no weird dead zones or "skips" even after 400 or so hours of gameplay (hard to tell as I use my pro controllers as well). You can also swap them for hall effect ones.
the pro controller is great, but too expensive and doesn't replace the joycon
Indeed. The Pro controller definitely feels the best, but I love my Gulikit KK3 Pro controller. Sadly, it's not really cheap but it's pretty damn good. Other than that one, I also have
DOYOKY Epoch (goes for $65 on their official wesbite) and it's somewhat decent, but KK3 Pro is much, much better in terms of features and build quality. Epoch, however, can be used in handheld mode (a bit bulky though) as well as work as two joy-cons, although a bit weird ones, depending on a game you're playing.
For "cheap" joy-cons, I'd probably go with
DOYOKY Classic RGB Joycon Slim Edition ($47 on their official website). You can probably find a 10% or so discount code as well and pray that shipping fee isn't too high. it has hall effect joysticks, a turbo function (per joy-con) and motion controls, rumble feature is pretty basic, it can (sometimes) wake up the console. Sadly, it lacks the IR port and an amiibo feature.