Homebrew SaveGame Manager GX

[tueidj]

It's longer than yours because it's better. Your version will always deinitialize ISFS regardless of if the program still wants to use it and the boolean result isn't globally stored, so the test gets executed every time the function is called. When you put a function in a library like obcd has done here it is wise to make the best effort to protect against people doing stupid things with it.

 

[JoostinOnline]

It's longer than yours because it's better. Your version will always deinitialize ISFS regardless of if the program still wants to use it and the boolean result isn't globally stored, so the test gets executed every time the function is called. When you put a function in a library like obcd has done here it is wise to make the best effort to protect against people doing stupid things with it.

That's a good point, lol.

 

[dj_skual]

Is this not compatible with System Menu 3.2?

i'm running the app under 3.2 or 4.3 without any problems...


OK guy's,
i think i will continue to use the is_neek3 detection as odbc had told me...

 

[JoostinOnline]

Is this not compatible with System Menu 3.2?

i'm running the app under 3.2 or 4.3 without any problems...


OK guy's,
i think i will continue to use the is_neek3 detection as odbc had told me...

Yeah, definitely stick with that. I hadn't considered people not wanting to run ISFS_Deinititialize so it's good that he made that modification.

 

[obcd]

It's not my idea. It comes from stfour's is_neek2 . He deserves the credit's for it. I just wanted their behavour to be identical.
When dj_skual asked for a proper way to detect neek, I proposed the library. The idea behind it is, if it get's broken someday. (hopefully never will), it will be seen in all programs using it. It's easier to pinpoint the problem that way.

 

[JoostinOnline]

It's not my idea. It comes from stfour's is_neek2 . He deserves the credit's for it. I just wanted their behavour to be identical.
When dj_skual asked for a proper way to detect neek, I proposed the library. The idea behind it is, if it get's broken someday. (hopefully never will), it will be seen in all programs using it. It's easier to pinpoint the problem that way.

Unless crediar changes the SNEEK folder to something else, I don't think it should ever break. Even if he does, there are other files and folders that could be checked. The problem with my original version that checked boot2 (again, I don't know if I was the first to think of it or not) was that it depended on
1) There never being another boot2 update
2) NEEK devs never changing the version back to v4

 

[obcd]

Overjoy used that boot2 check in his modified wiiflow (joyflow)
I never really had problems with it, as I used my init_uneek_fs for that detection, and I normally only use neek2o that supports it.
Even if the sneek folder name get's changed, this doesn't mean a sneek folder can still exist and be used for the check on the neek nand drive.
If nintendo adds a sneek folder to their nand, we have a problem.

 

[JoostinOnline]

Overjoy used that boot2 check in his modified wiiflow (joyflow)
I never really had problems with it, as I used my init_uneek_fs for that detection, and I normally only use neek2o that supports it.
Even if the sneek folder name get's changed, this doesn't mean a sneek folder can still exist and be used for the check on the neek nand drive.
If nintendo adds a sneek folder to their nand, we have a problem.

How long ago was that?

 

[obcd]

march or april 2011. You might be able to locate the first joyflow thread here on gbatemp.

 

[JoostinOnline]

Okay, that was long before ProgressiveSwitch, so Overjoy thought of it first.

 

[obcd]

So we can't blame you for it I guess.

 

[tueidj]

IMO the old check that savegame-manager-gx used (checking for read/write permissions on a file that shouldn't grant it) was better.

 

[obcd]

And why would that be, if I may ask?

 

[tueidj]

Because it doesn't rely on any hardcoded names of directories/files that could easily be changed in the future.

 

[dj_skual]

ok,
do u think i need to revert to my old neek detection way?

 

[JoostinOnline]

ok,
do u think i need to revert to my old neek detection way?

The new one isn't nearly as likely to break as the old boot2 version one, and should be fixable by changing one string if the SNEEK folder is ever renamed, but if there are no downsides to the method tueidj is referring to you might consider changing it just to be safe.

 

[dj_skual]

if obcd is ok to add in is lib:

bool is_neek4(bool isfsinit) 
{
confirm_neek = false;

u32 ownerID;
u16 groupID;
u8  attributes;
u8  ownerperm;
u8  groupperm;
u8  otherperm;

if(isfsinit) ISFS_Initialize();

ISFS_GetAttr("/shared1/00000000.app", &ownerID, &groupID, &attributes, &ownerperm, &groupperm, &otherperm);

if(otherperm)
confirm_neek = true;

if(isfsinit) ISFS_Deinitialize();

return confirm_neek;
}

 

[JoostinOnline]

I'm still a bit of a newbie at C (I REALLY need to get a tutorial book on it), but if you added:

static u32 _fs_initialized;

to the library (the variable isn't in isfs.h, only in isfs.c), couldn't you just refer to it to see if it has been initialized, eliminating the need for a boolean argument?

Sorry if that is nonsense, lol.

 

[dj_skual]

I'm still a bit of a newbie at C (I REALLY need to get a tutorial book on it), but if you added:

static u32 _fs_initialized;

to the library (the variable isn't in isfs.h, only in isfs.c), couldn't you just refer to it to see if it has been initialized, eliminating the need for a boolean argument?

Sorry if that is nonsense, lol.

i've already looked in isfs.h but if the variable is only in .c, i can't have acces to this one.
but all that is only usefull if obcd want to add this in his lib.

 

[tueidj]

I'm still a bit of a newbie at C (I REALLY need to get a tutorial book on it), but if you added:

static u32 _fs_initialized;

to the library (the variable isn't in isfs.h, only in isfs.c), couldn't you just refer to it to see if it has been initialized, eliminating the need for a boolean argument?

Static global variables are only visible to code within the same .c file, they can't be accessed by name from anywhere else even if you copy the definition (you end up with a new static variable with the same name, which is why as a rule you should never use "static" in a header unless you like debugging seemingly impossible situations).