Hacking Possible fix for the WBFS corruption

AllWiidUp · Apr 12, 2009

Looking at the WBFS alloc and free functions I noticed an off by 1 error, that likely frees the wrong block.

in libwbfs.c:

CODE--- a/libwbfs.cÂÂ 2009-03-31 18:26:00.000000000 -0700
+++ b/libwbfs.cÂÂÂÂ 2009-04-12 12:28:23.516024000 -0700
@@ -389,8 +389,8 @@
}
static void free_block(wbfs_t *p,int bl)
{
-ÂÂÂÂÂÂÂÂint i = bl/(32);
-ÂÂÂÂÂÂÂÂint j = bl&31;
+ÂÂÂÂÂÂÂÂint i = (bl-1)/(32);
+ÂÂÂÂÂÂÂÂint j = (bl-1)&31;
ÂÂÂÂÂÂÂÂ u32 v = wbfs_ntohl(p->freeblks);
ÂÂÂÂÂÂÂÂ p->freeblks = wbfs_htonl(v | 1freeblks);
ÂÂÂÂÂÂÂÂp->freeblks = wbfs_htonl(v | 1wlba_table); // bl = info->wlba_table
ÂÂÂÂÂÂÂÂÂÂif (iwlba)
ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂfree_block(p,iwlba); // should have beenÂÂfree_block(p,iwlba - 1);[/code]
but since "alloc_block" adds the +1 then "free_block" should have the -1, otherwise someone else might introduce the bug again, if the use free_block in another place since both block functions are used for "wlba_table".

EDIT:
WiiNinja compiled and tested a windows version with the fix and all it well ;P
WBFS.Windows.with.free.space.fix

now supported in WBFuse

Managers with Support:
WBFS Manager 2.2

Loaders with support:
KongsNutz Loader
Waninkoko v1.4

Mark McDonut · Apr 12, 2009

you should contact qwiirk or waninkoko, you really may be on to something.

AllWiidUp · Apr 12, 2009

Mark McDonut said:
you should contact qwiirk or waninkoko, you really may be on to something.

I don't know Kwiirk's contact info and since he did up this version, I thought I'd put it out there in case he could see.

OuahOuah · Apr 12, 2009

He's on Wiibrew

FenrirWolf · Apr 12, 2009

So in what manner would this possibly fix the corruption? Would it cause a game to move the other games out of the way instead of overwriting them or something?

KongsNutz · Apr 12, 2009

pretty much .......yeh

FoGBaV · Apr 12, 2009

Can someone confirm this fix - this would be the best Loader out there ... a Loader with no corruption in the file system ! 8)

FenrirWolf · Apr 12, 2009

From what I gather this has to do with the wbfs filesystem itself and not any loader application, but correct me if I'm wrong.

FoGBaV · Apr 12, 2009

Its the libwbfs ... so its part of something when compiled ... so the usb loader has this code in it i guess ...
also the wbfs tools ...

maglat · Apr 12, 2009

I think we musst reformat our hdd`s when they build in this fix

FenrirWolf · Apr 12, 2009

I'm thinking the same thing. It'll be well worth it since you have to reinstall games when they get corrupted anyway.

djtaz · Apr 12, 2009

It would be a great find if its the fix - its been bugging everyone and makes the format seem a little unstable for most.
well done AllWiidup

Blue-K · Apr 12, 2009

That's awesome!!!

.Good work! Have you maybe also found the bug why games can't be dumped by the Wii to a Partition over 512GB

? That would be also awesome

.

waninkoko · Apr 12, 2009

You're completely right. It frees an incorrect block (we don't free the first block of the game, but we free the first block next to the last block of the game).

wiiNinja · Apr 12, 2009

QUOTE said:
You're completely right. It frees an incorrect block (we don't free the first block of the game, but we free the first block next to the last block of the game).

Finally, the bug is found. Thanks AllWiidup.

--=ZerO=-- · Apr 12, 2009

waninkoko said:
You're completely right. It frees an incorrect block (we don't free the first block of the game, but we free the first block next to the last block of the game).

So... i see... i'm sure u and kwiirk will fix this very soon... CIOS11 is on it's way.

U guys are great!

Linuks · Apr 12, 2009

USB Loader 1.3 is already here.

--=ZerO=-- · Apr 12, 2009

Linuks said:
USB Loader 1.3 is already here.

yeah, and? I thougth it's a problem of libwbfs and not the loader...

wiiNinja · Apr 12, 2009

QUOTE said:
yeah, and? I thougth it's a problem of libwbfs and not the loader...

THe loader contains wbfs code for adding/deleting ISOs.

Version 1.3 does not fix this problem. I suspect 1.4.

AllWiidUp · Apr 12, 2009

Thanks wiiNinja for compiling and testing the fix, to verify it works.

Hacking Possible fix for the WBFS corruption

Well-Known Member

GBATemp's Resident Ghostbuster

Well-Known Member

Well-Known Member

Well-Known Member

[Team Oceanic]

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

PM's Full - Wadder Me

No right of appeal.

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Popular threads in this forum