ROM Hack [Release] Gen 1 Pokemon VC wild encounter DV NTR Overlay

shadowofdarkness · Feb 25, 2017

mbcrazed said:
View attachment 79421 View attachment 79422 View attachment 79423 Tested Crystal. The party Pokémon and wild Pokémon check out. Don't know about eggs. The old man has the odd egg, and I pick it up from him but it doesn't change anything. It would be cool to get the eggs working so I can get my shiny pichu!

We also have not done Japanese yet so even the wild and party could be wrong. Just because it's showing numbers doesn't mean they are correct. Just that that offset in RAM has data and is not zeroed out.

Any two bytes will show results regardless if they're correct or not.

Veund · Feb 25, 2017

shadowofdarkness said:
We also have not done Japanese yet so even the wild and party could be wrong. Just because it's showing numbers doesn't mean they are correct. Just that that offset in RAM has data and is not zeroed out.

Any two bytes will show results regardless if they're correct or not.

ahh damn i missed that, the Japanese version i uploaded only works in R/B/Y/G

shadowofdarkness · Feb 25, 2017

mbcrazed said:
View attachment 79421 View attachment 79422 View attachment 79423 Tested Crystal. The party Pokémon and wild Pokémon check out. Don't know about eggs. The old man has the odd egg, and I pick it up from him but it doesn't change anything. It would be cool to get the eggs working so I can get my shiny pichu!

I just noticed when looking for it that Traiver doesn't have Japanese versions, so I have no idea what release you would have to find the correct offset.

mbcrazed · Feb 25, 2017

shadowofdarkness said:
I just noticed when looking for it that Traiver doesn't have Japanese versions, so I have no idea what release you would have to find the correct offset.

It's the U.S. version! My 3DS is just Japanese so it shows Japanese text! It's definitely the English version

shadowofdarkness · Feb 25, 2017

mbcrazed said:
It's the U.S. version! My 3DS is just Japanese so it shows Japanese text! It's definitely the English version

OK then it must be working. I have never played Crystal but have heard of the Odd Egg. I don't think it's stored before you pick it up since you can soft reset for different ones.

You could try saving then pickup the Odd Egg and put it in the first spot of your party to check it that way. Then soft reset if it's not shiny. I heard it's a 14% chance so not bad. Sadly this only shows DVs so you will know if it's shiny fast but not what species since I heard you get a random one from a list.

Veund · Feb 25, 2017

my code in 0.8.6 did work and it only displays on the unclaimed egg

but i have reworked the code and added some formatting since and this is what I have opinions?
@shadowofdarkness the "(!)" can be changed if you would just prefer a "!" or other symbol it just doesn't take up any extra room this way

shadowofdarkness · Feb 25, 2017

The "(!)" looks good.

greenDarkness555 · Feb 25, 2017

So in my testing I found that it is impossible to close the Party Pokemon overlay. Also, when there are no Pokemon in the Daycare and No egg is ready, it still says that there is an egg available for pick up. I'm doing some breeding now to see how that runs.

Veund · Feb 25, 2017

greenDarkness555 said:
So in my testing I found that it is impossible to close the Party Pokemon overlay. Also, when there are no Pokemon in the Daycare and No egg is ready, it still says that there is an egg available for pick up. I'm doing some breeding now to see how that runs.

The party pokemon overlay is fixed onece you enter and leave a wild battle its a known bug to do with how gen 2 deals with something in a different way to gen 1 its a known bug and why this any of the recent versions havent been updated to #33 yet

greenDarkness555 · Feb 25, 2017

Veund said:
The party pokemon overlay is fixed onece you enter and leave a wild battle its a known bug to do with how gen 2 deals with something in a different way to gen 1 its a known bug and why this any of the recent versions havent been updated to #33 yet

Ah, I see. Should I update to 8.6-B and continue testing? Or stick with what I have?

shadowofdarkness · Feb 25, 2017

greenDarkness555 said:
So in my testing I found that it is impossible to close the Party Pokemon overlay. Also, when there are no Pokemon in the Daycare and No egg is ready, it still says that there is an egg available for pick up. I'm doing some breeding now to see how that runs.

The detection for eggs being ready was a guess because I couldn't find a RAM map good enough for Crystal to list the correct offset just Gold and Silver. I will have to keep looking though since I wouldn't be able to find it on my own. Without a RAM map. Finding 1 individual bit would be to hard.

Veund · Feb 25, 2017

shadowofdarkness said:
The detection for eggs being ready was a guess because I couldn't find a RAM map good enough for Crystal to list the correct offset just Gold and Silver. I will have to keep looking though since I wouldn't be able to find it on my own. Without a RAM map. Finding 1 individual bit would be to hard.

I use math if we know what one offset is

Say for example

Cff1=891ab3
And we need d057 then do this
(891ab3-cff1)+d057

Thats how i have been powering through the gen 1 international offsets find 1 then math the rest, then test most if the time I'm right

shadowofdarkness · Feb 25, 2017

Veund said:
I use math if we know what one offset is

Say for example

Cff1=891ab3
And we need d057 then do this
(891ab3-cff1)+d057

Thats how i have been powering through the gen 1 international offsets find 1 then math the rest

The problem in this case is that Crystal has a different RAM map compared to Gold and Silver so it's not just a different base game offset and I don't know the Crystal offset for that flag

For example the wild DV's are 0xD0F5 in GS but they are at 0xD20C in Crystal

Veund · Feb 25, 2017

shadowofdarkness said:
The problem in this case is that Crystal has a different RAM map compared to Gold and Silver so it's not just a different base game offset and I don't know the Crystal offset for that flag

For example the wild DV's are 0xD0F5 in GS but they are at 0xD20C in Crystal

Of that is weird, so there is a solution, get a dump of your game whilst an egg is ready, collect that egg do this 3 (or so) times

Use jksv to back up pokemon crystals save

Open said save in your favorite hex editor (hxd for me ) remove the last line (8000?) Then save it

Open in pkhex then read your pokemons dv's convert to hex then search for your data to find the offset

shadowofdarkness · Feb 25, 2017

I think I found it in a RAM map the Crystal offset may be 0xdef5 (3ds 0x8A2FE59)

@greenDarkness555 can you please test this quick version with the egg detection for Crystal It's still based on my last code not Veund's though since I still had it and didn't get his yet.

greenDarkness555 · Feb 26, 2017

shadowofdarkness said:
I think I found it in a RAM map the Crystal offset may be 0xdef5 (3ds 0x8A2FE59)

@greenDarkness555 can you please test this quick version with the egg detection for Crystal It's still based on my last code not Veund's though since I still had it and didn't get his yet.

Just got home. I'll give it a shot right now.

greenDarkness555 · Feb 26, 2017

shadowofdarkness said:
I think I found it in a RAM map the Crystal offset may be 0xdef5 (3ds 0x8A2FE59)

@greenDarkness555 can you please test this quick version with the egg detection for Crystal It's still based on my last code not Veund's though since I still had it and didn't get his yet.

I never got a notification for the egg being ready. Also, on a separate note. My odd egg was a 0 DV Tyrogue haha.

shadowofdarkness · Feb 26, 2017

greenDarkness555 said:
I never got a notification for the egg being ready. Also, on a separate note. My odd egg was a 0 DV Tyrogue haha.

I'll have to keep looking then.

greenDarkness555 · Feb 26, 2017

shadowofdarkness said:
I'll have to keep looking then.

I'm sure that we're just on the edge of it.

Veund · Feb 26, 2017

@shadowofdarkness
ok so i just got home and made this table just for the wild dv Pokemon variable

as japan is the lowest i should base it off the jap offsets then add on the difference for each language?

ROM Hack [Release] Gen 1 Pokemon VC wild encounter DV NTR Overlay

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Attachments

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Attachments

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Well-Known Member

Similar threads

Popular threads in this forum