I don't have PR requests that just keep commenting out lines. I have one PR request where I added support for dance mat; however - I was previously using an old build from September 2019 as the latest code apparently has issues with USB HID. I narrowed down the commit that introduced this USB HID issue (which was around September 30th 2019) and found the only code change obviously related to USB HID in that commit was the addition of that line. The commit description for the commit where FIX94 introduced that line of code is:
"moved things around to be overall a bit cleaner and more stable"
I commented that line out and gave it a try. It seems to work for me. It is a workaround/potential solution instead of just continuging to use a build from September 2019 (like many people are doing). My second PR request specifically mentions that I did this - launching from usbloadergx has not worked in any build since September 30th 2019 which is when that line was introduced. It is a workaround/potential fix - but not necessarily the actual fix that should be merged.. though my PR is there to document a workaround which could benefit people or even help someone come up with a better fix.
Obviously just commenting lines out is not a good idea; however, it was the addition of that line that introduced a problem when launching injects or launching from usbloaderGX back in the day. I make it quite clear that this seems to workaround the issue but *might* break other things.
Please dont claim my PR's are just commenting lines out haphazardly. ... read the entire PR, all associated code changes, their comments and links to other issues/PR.s Unfortunately Nintendont hasnt been worked on in a long time, and the current state of the codebase isn't pristine (it doesnt build and has USB HID issues since September 2019) Unfortunately FIX94 has not been working on Nintendont for quite some time -- which is a big loss for the community... so nobody is really maintaining the code base. It is better to investigate and partially fix/document then not do anythnig at all.
I currently have 2 PR's open:
The first
https://github.com/FIX94/Nintendont/pull/805 implements dance pad support, but also has some changes from another PR:
https://github.com/FIX94/Nintendont/pull/778 otherwise it wont build (has nothing to do with my changes for dance pad support, but rather just doesnt build in general)
The second
https://github.com/FIX94/Nintendont/pull/808 refers to the single commented out line for which the commit message clearly indicates it might break something... but is there to fix/workaround the HID issue introduced in September 2019. You can read more about this issue here:
https://github.com/FIX94/Nintendont/issues/712
The idea is that when someone actually looks into that issue they will see the workaround that might help them either (a) verify it is a good fix or (b) come up with a better fix. OR when someone addresses the PR, they might have more insight into the issue to again either verify or come up with a better fix. Unfortunately it might be the case, that the issue and/or PR are not looked at for a long time or ever...
But if people want to try my workaround out and do find it breaking things, their feedback might help me also come up with a better fix. It seems there are many people simply using a build from before September 2019 because of this issue.. so it would be nice to actually come up with a fix for it.
